[webkit-reviews] review granted: [Bug 176065] Switch HTMLMediaElement to release logging : [Attachment 319414] Updated patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 30 15:31:32 PDT 2017


Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 176065: Switch HTMLMediaElement to release logging
https://bugs.webkit.org/show_bug.cgi?id=176065

Attachment 319414: Updated patch.

https://bugs.webkit.org/attachment.cgi?id=319414&action=review




--- Comment #4 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 319414
  --> https://bugs.webkit.org/attachment.cgi?id=319414
Updated patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=319414&action=review

> Source/WebCore/html/HTMLMediaElement.h:41
> +#include <pal/Logger.h>

nit: I assume this is needed for the "private PAL::LogHelper" subclass. Can we
pull that out into its own file?


More information about the webkit-reviews mailing list