[webkit-reviews] review granted: [Bug 176082] Implement all of "Register" right up until where the script is fetched : [Attachment 319372] Patch

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 176082: Implement all of "Register" right up until where the script is
fetched
https://bugs.webkit.org/show_bug.cgi?id=176082

Attachment 319372: Patch

https://bugs.webkit.org/attachment.cgi?id=319372&action=review




--- Comment #3 from Andy Estes <aestes at apple.com> ---
Comment on attachment 319372
  --> https://bugs.webkit.org/attachment.cgi?id=319372
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319372&action=review

> Source/WebCore/workers/service/ServiceWorkerContainer.cpp:170
> +    ScopeGuard guard([this, job = &job] {

Why not just capture &job?

> Source/WebCore/workers/service/ServiceWorkerRegistration.cpp:37
> +{
> +}

Do you need to call suspendIfNeeded() here now that this is an ActiveDOMObject?