[webkit-reviews] review granted: [Bug 175925] Initial reference implementation scaffolding for WebGPU Shading Language prototype : [Attachment 319284] the patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 175925: Initial reference implementation scaffolding for WebGPU Shading
Language prototype
https://bugs.webkit.org/show_bug.cgi?id=175925

Attachment 319284: the patch

https://bugs.webkit.org/attachment.cgi?id=319284&action=review




--- Comment #29 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 319284
  --> https://bugs.webkit.org/attachment.cgi?id=319284
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319284&action=review

At a high level, this seems fine. I really appreciate the current design's
primary goal being clarity. I'd like to take this and run with it; there are
lots of ideas I have for what we can do next with it. It doesn't seem that
being extremely detail-oriented would be valuable for this first patch, as this
is intended to be platform for further evolution of the language. There is a
chance that some piece of this code will end up in production, but that chance
is slim.

> Tools/ArrayLangRI/EBufferBuilder.js:33
> +	   // NOTE: I don't think that this is necessary.

FIXME?