[webkit-reviews] review granted: [Bug 174924] Strings need to be in some kind of gigacage : [Attachment 319297] the ptach

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 174924: Strings need to be in some kind of gigacage
https://bugs.webkit.org/show_bug.cgi?id=174924

Attachment 319297: the ptach

https://bugs.webkit.org/attachment.cgi?id=319297&action=review




--- Comment #38 from Oliver Hunt <oliver at apple.com> ---
Comment on attachment 319297
  --> https://bugs.webkit.org/attachment.cgi?id=319297
the ptach

View in context: https://bugs.webkit.org/attachment.cgi?id=319297&action=review

> Source/JavaScriptCore/runtime/JSString.cpp:182
> +    [&] () {
> +	   if (length() > maxLengthForOnStackResolve) {

I'm curious about this change (I apparently don't have the context for why we
want to do this in a block)