[webkit-reviews] review granted: [Bug 176063] REGRESSION(r220235): Web Inspector: Global search should not happen incrementally : [Attachment 319279] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Devin Rousso <webkit at devinrousso.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 176063: REGRESSION(r220235): Web Inspector: Global search should not happen
incrementally
https://bugs.webkit.org/show_bug.cgi?id=176063

Attachment 319279: [PATCH] Proposed Fix

https://bugs.webkit.org/attachment.cgi?id=319279&action=review




--- Comment #2 from Devin Rousso <webkit at devinrousso.com> ---
Comment on attachment 319279
  --> https://bugs.webkit.org/attachment.cgi?id=319279
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=319279&action=review

r=me

> Source/WebInspectorUI/UserInterface/Base/Main.js:401
> +    const incremental = false;
> +    this._searchToolbarItem = new WI.SearchBar("inspector-search",
WI.UIString("Search"), incremental);

NIT: since this is false, I don't think you need to include it at all.