[webkit-reviews] review granted: [Bug 176043] Begin transition to modern IPC decoding : [Attachment 319288] Patch

[bugzilla-daemon at webkit.org]

JF Bastien <jfbastien at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 176043: Begin transition to modern IPC decoding
https://bugs.webkit.org/show_bug.cgi?id=176043

Attachment 319288: Patch

https://bugs.webkit.org/attachment.cgi?id=319288&action=review




--- Comment #10 from JF Bastien <jfbastien at apple.com> ---
Comment on attachment 319288
  --> https://bugs.webkit.org/attachment.cgi?id=319288
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319288&action=review

r=me

> Source/WebKit/Platform/IPC/ArgumentCoder.h:46
> +    static auto decode(Decoder& decoder, U& u) ->
std::enable_if_t<!UsesModernDecoder<U>::value, bool>

I'd make enable_if a default template parameter instead. De-clutters the return
type.

> Source/WebKit/Shared/WebPageCreationParameters.cpp:264
> +    return { WTFMove(parameters) };

Do you need the curls here? Or can you implicitly get optional(U&&) ?

> Source/WebKit/Shared/WebPageGroupData.cpp:59
> +    return { { id, pageGroupID, visibleToInjectedBundle,
visibleToHistoryClient, userContentControllerIdentifier } };

I'm not a fan of multi-bools but separate change... I like enum class here.