[webkit-reviews] review granted: [Bug 176070] CallTracingCallback should ignore `readonly attribute` : [Attachment 319289] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Devin Rousso
<webkit at devinrousso.com>'s request for review:
Bug 176070: CallTracingCallback should ignore `readonly attribute`
https://bugs.webkit.org/show_bug.cgi?id=176070

Attachment 319289: Patch

https://bugs.webkit.org/attachment.cgi?id=319289&action=review




--- Comment #2 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 319289
  --> https://bugs.webkit.org/attachment.cgi?id=319289
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319289&action=review

r=me

> Source/WebCore/ChangeLog:8
> +	   Updates existing bindings test with more cases.

It seems like the thing to note is that the CallTracingCallback is not invoked
for readonly attributes. Aren't the test cases just auto-generated?

> Source/WebCore/ChangeLog:12
> +	   If the attribute is makred `readonly` do not add CallTracer logic.

makred -> marked