[webkit-reviews] review granted: [Bug 176055] Setting the cache storage engine root path according the session WebsiteDataStore : [Attachment 319255] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 176055: Setting the cache storage engine root path according the session
WebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=176055

Attachment 319255: Patch

https://bugs.webkit.org/attachment.cgi?id=319255&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 319255
  --> https://bugs.webkit.org/attachment.cgi?id=319255
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319255&action=review

> Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp:53
> +    auto addResult = globalEngineMap().add(sessionID, nullptr);

This can probably still use ensure.

> Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp:357
> +	   channel->read(0, std::numeric_limits<size_t>::max(),
m_ioQueue.get(), [callback = WTFMove(callback)](const Data& data, int error)
mutable {
> +	       RunLoop::main().dispatch([callback = WTFMove(callback), data,
error]() mutable {

Will this create a copy of data, or just capture a reference to something that
will probably be gone?