[webkit-reviews] review granted: [Bug 175895] [DFG] Add constant folding rule to convert CompareStrictEq(Untyped, Untyped [with non string cell constant]) to CompareEqPtr(Untyped) : [Attachment 319144] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 175895: [DFG] Add constant folding rule to convert CompareStrictEq(Untyped,
Untyped [with non string cell constant]) to CompareEqPtr(Untyped)
https://bugs.webkit.org/show_bug.cgi?id=175895

Attachment 319144: Patch

https://bugs.webkit.org/attachment.cgi?id=319144&action=review




--- Comment #11 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 319144
  --> https://bugs.webkit.org/attachment.cgi?id=319144
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319144&action=review

r=me

> Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:158
> +		       if (isNonStringCellConstant(child1Constant)) {
> +			  
node->convertToCompareEqPtr(m_graph.freezeStrong(child1Constant.asCell()),
node->child2());
> +			   changed = true;
> +		       } else if (isNonStringCellConstant(child2Constant)) {
> +			  
node->convertToCompareEqPtr(m_graph.freezeStrong(child2Constant.asCell()),
node->child1());
> +			   changed = true;
> +		       }

When we do BigInt, we need to make sure we change this rule...