[webkit-reviews] review granted: [Bug 176041] Web Inspector: Optimize View.prototype.removeSubview : [Attachment 319263] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 176041: Web Inspector: Optimize View.prototype.removeSubview
https://bugs.webkit.org/show_bug.cgi?id=176041

Attachment 319263: Patch

https://bugs.webkit.org/attachment.cgi?id=319263&action=review




--- Comment #13 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 319263
  --> https://bugs.webkit.org/attachment.cgi?id=319263
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319263&action=review

r=me, with a nit.

> Source/WebInspectorUI/UserInterface/Base/Utilities.js:499
> +	   for (let i = this.length - 1; i >= 0; --i) {

Iterating from the end of the array feels weird now that it's no longer
necessary. Plus the test output currently states that "remove should only
remove the first matching value".