[webkit-reviews] review granted: [Bug 176056] [Win] A WTF test is timing out in run-api-tests. : [Attachment 319257] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 29 10:49:38 PDT 2017


Brent Fulgham <bfulgham at webkit.org> has granted Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 176056: [Win] A WTF test is timing out in run-api-tests.
https://bugs.webkit.org/show_bug.cgi?id=176056

Attachment 319257: Patch

https://bugs.webkit.org/attachment.cgi?id=319257&action=review




--- Comment #2 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 319257
  --> https://bugs.webkit.org/attachment.cgi?id=319257
Patch

I think we should use a conditional here so we don't allow millisecond-accurate
platforms to regress.

#if PLATFORM(WIN)
auto sleepAmount = std::chrono::milliseconds(20);
#else
auto sleepAmount = std::chrono::milliseconds(10);
#endif


More information about the webkit-reviews mailing list