[webkit-reviews] review granted: [Bug 176032] [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions : [Attachment 319200] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Andy Estes
<aestes at apple.com>'s request for review:
Bug 176032: [Cocoa] Upstream CFNetwork-related WebKitSystemInterface functions
https://bugs.webkit.org/show_bug.cgi?id=176032

Attachment 319200: Patch

https://bugs.webkit.org/attachment.cgi?id=319200&action=review




--- Comment #5 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 319200
  --> https://bugs.webkit.org/attachment.cgi?id=319200
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319200&action=review

> Source/WebCore/platform/network/mac/CookieJarMac.mm:276
> +static unsigned httpCookieAcceptPolicy(CFHTTPCookieStorageRef cookieStorage)

Let's have this return a HTTPCookieAcceptPolicy

> Source/WebCore/platform/network/mac/CookieJarMac.mm:279
> +	   // FIXME: The fallback to NSHTTPCookieStorage should not be present
when USE(CFNETWORK) is defined in WebKit.

This is an old comment.  We renamed this to USE(CFURLCONNECTION), and I'm not
sure if that applies.