[webkit-reviews] review granted: [Bug 175620] [WebCrypto] Push WorkQueue dispatches for HKDF, HMAC, PBKDF2 algorithms into shared code : [Attachment 319070] Patch

[bugzilla-daemon at webkit.org]

Jiewen Tan <jiewen_tan at apple.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 175620: [WebCrypto] Push WorkQueue dispatches for HKDF, HMAC, PBKDF2
algorithms into shared code
https://bugs.webkit.org/show_bug.cgi?id=175620

Attachment 319070: Patch

https://bugs.webkit.org/attachment.cgi?id=319070&action=review




--- Comment #8 from Jiewen Tan <jiewen_tan at apple.com> ---
Comment on attachment 319070
  --> https://bugs.webkit.org/attachment.cgi?id=319070
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319070&action=review

Looks good to me. r=me. Good job.

> Source/WebCore/crypto/mac/CryptoAlgorithmHMACMac.cpp:102
> +    return signature.size() == expectedSignature.size() &&
!constantTimeMemcmp(expectedSignature.data(), signature.data(),
expectedSignature.size());

Forget to copy a comment here.