[webkit-reviews] review denied: [Bug 175265] [GTK][WPE] webkit_cookie_manager_delete_all_cookies doesn't delete the cookies if called before a web process is running : [Attachment 318242] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 28 09:34:53 PDT 2017


Brady Eidson <beidson at apple.com> has denied  review:
Bug 175265: [GTK][WPE] webkit_cookie_manager_delete_all_cookies doesn't delete
the cookies if called before a web process is running
https://bugs.webkit.org/show_bug.cgi?id=175265

Attachment 318242: Patch

https://bugs.webkit.org/attachment.cgi?id=318242&action=review




--- Comment #14 from Brady Eidson <beidson at apple.com> ---
Comment on attachment 318242
  --> https://bugs.webkit.org/attachment.cgi?id=318242
Patch

If a WebsiteDataStore is going to keep a set of "associated WebProcessPools"
like this, then WebProcessPool itself has to do the association in its
constructor and destructor. It's folly to mix API objects and IMPL objects like
this.


More information about the webkit-reviews mailing list