[webkit-reviews] review granted: [Bug 175539] [WebCrypto] Push WorkQueue dispatches for AES algorithms into shared code : [Attachment 319068] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Zan Dobersek <zan at falconsigh.net>'s
request for review:
Bug 175539: [WebCrypto] Push WorkQueue dispatches for AES algorithms into
shared code
https://bugs.webkit.org/show_bug.cgi?id=175539

Attachment 319068: Patch

https://bugs.webkit.org/attachment.cgi?id=319068&action=review




--- Comment #17 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 319068
  --> https://bugs.webkit.org/attachment.cgi?id=319068
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319068&action=review

> Source/WebCore/crypto/algorithms/CryptoAlgorithmAES_CBC.h:54
> +    static ExceptionOr<Vector<uint8_t>>
platformEncrypt(CryptoAlgorithmParameters&, const CryptoKey&, const
Vector<uint8_t>&);
> +    static ExceptionOr<Vector<uint8_t>>
platformDecrypt(CryptoAlgorithmParameters&, const CryptoKey&, const
Vector<uint8_t>&);

Seems like these should take CryptoAlgorithmAesCbcCfbParams rather than
CryptoAlgorithmParameters, and CryptoKeyAES rather than CryptoKey. (Same for
others below). Not needed for this change, but seems like a nice improvement
for the future so the platforms don't have to do the downcast themselves.