[webkit-reviews] review granted: [Bug 176011] [iOS WK2] Web process crashes after changing selection to the end of the document when speaking a selection : [Attachment 319156] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 176011: [iOS WK2] Web process crashes after changing selection to the end
of the document when speaking a selection
https://bugs.webkit.org/show_bug.cgi?id=176011

Attachment 319156: Patch

https://bugs.webkit.org/attachment.cgi?id=319156&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 319156
  --> https://bugs.webkit.org/attachment.cgi?id=319156
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319156&action=review

> Source/WebCore/editing/Editing.cpp:1095
> +VisiblePosition visiblePositionForPositionWithOffset(const VisiblePosition&
position, int32_t offset)

We should make this function take unsigned instead of int32_t. It's
non-sensical to have a negative offset.