[webkit-reviews] review granted: [Bug 175850] [SOUP] Update cookie jar implementation to filter out secure cookies : [Attachment 319130] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Michael Catanzaro
<mcatanzaro at igalia.com>'s request for review:
Bug 175850: [SOUP] Update cookie jar implementation to filter out secure
cookies
https://bugs.webkit.org/show_bug.cgi?id=175850

Attachment 319130: Patch

https://bugs.webkit.org/attachment.cgi?id=319130&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 319130
  --> https://bugs.webkit.org/attachment.cgi?id=319130
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319130&action=review

>> Source/WebCore/platform/network/soup/CookieJarSoup.cpp:92
>> +	while (item) {
> 
> I guess I should probably only enter this loop if url.protocolIs("https"),
since it doesn't do anything otherwise. (libsoup should not return secure
cookies except in that case.)

Makes sense.

> LayoutTests/platform/gtk/TestExpectations:-3375
> -

Yay!