[webkit-reviews] review canceled: [Bug 176004] Fix incorrect enum in atBoundaryOfGranularity call : [Attachment 319123] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has canceled Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 176004: Fix incorrect enum in atBoundaryOfGranularity call
https://bugs.webkit.org/show_bug.cgi?id=176004

Attachment 319123: Patch

https://bugs.webkit.org/attachment.cgi?id=319123&action=review




--- Comment #2 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 319123
  --> https://bugs.webkit.org/attachment.cgi?id=319123
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319123&action=review

Nice find! r=me (though, this might still need a WK2R?)

> Source/WebKit/ChangeLog:6
> +	   Enum that was being used was incorrect, as that case in not covered
in called function.

The ChangeLog description should go under the "Reviewed by" line. (also, it
looks like you meant "is not covered" instead of "in not covered").

> Source/WebKit/ChangeLog:7
> +	   Resulted in a no-op, expected behavior will happen now.

I think a sentence or two describing the "expected behavior" here would be
helpful. What change in behavior did you observe after making this tweak?