[webkit-reviews] review granted: [Bug 175993] Land stubs for File and Directory Entries API interfaces : [Attachment 319097] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 25 14:55:05 PDT 2017


Ryosuke Niwa <rniwa at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 175993: Land stubs for File and Directory Entries API interfaces
https://bugs.webkit.org/show_bug.cgi?id=175993

Attachment 319097: Patch

https://bugs.webkit.org/attachment.cgi?id=319097&action=review




--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 319097
  --> https://bugs.webkit.org/attachment.cgi?id=319097
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319097&action=review

> Source/WebCore/Modules/entriesapi/FileSystemDirectoryEntry.idl:34
> +		    optional FileSystemFlags options,
> +		    optional FileSystemEntryCallback? successCallback,
> +		    optional ErrorCallback? errorCallback);

Can we use WebKit style indentation (4 spaces to the right of avoid getFile)
instead?

> Source/WebCore/Modules/entriesapi/FileSystemDirectoryEntry.idl:39
> +			 optional FileSystemFlags options,
> +			 optional FileSystemEntryCallback? successCallback,
> +			 optional ErrorCallback? errorCallback);

Ditto.


More information about the webkit-reviews mailing list