[webkit-reviews] review granted: [Bug 163955] Explore increasing max JSString::m_length to UINT_MAX. : [Attachment 319085] Patch

[bugzilla-daemon at webkit.org]

JF Bastien <jfbastien at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 163955: Explore increasing max JSString::m_length to UINT_MAX.
https://bugs.webkit.org/show_bug.cgi?id=163955

Attachment 319085: Patch

https://bugs.webkit.org/attachment.cgi?id=319085&action=review




--- Comment #6 from JF Bastien <jfbastien at apple.com> ---
Comment on attachment 319085
  --> https://bugs.webkit.org/attachment.cgi?id=319085
Patch

OK Keith pointed out that size_t is misleading because string's .length returns
unsigned. The assumption I have now is that tryMakeString will fail on its own,
so this patch is OK. Please confirm that's the case before committing. r=me if
so. Maybe needs a test?