[webkit-reviews] review granted: [Bug 175851] Introduce ServerWorkerRegistration task queues : [Attachment 319055] Patch

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 175851: Introduce ServerWorkerRegistration task queues
https://bugs.webkit.org/show_bug.cgi?id=175851

Attachment 319055: Patch

https://bugs.webkit.org/attachment.cgi?id=319055&action=review




--- Comment #28 from Andy Estes <aestes at apple.com> ---
Comment on attachment 319055
  --> https://bugs.webkit.org/attachment.cgi?id=319055
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319055&action=review

> Source/WebCore/workers/service/ServiceWorkerJobData.h:41
> +    ServiceWorkerJobData(uint64_t connectionIdentifier);
> +    ServiceWorkerJobData(const ServiceWorkerJobData&);

Should these be explicit?

> Source/WebCore/workers/service/server/SWServer.cpp:108
> +    {
> +	   Locker<Lock> locker(m_taskThreadLock);
> +    }

Not sure why this necessary, but you told me in person that this was needed in
IndexedDB and might be needed here too. If this is necessary then a comment
would be helpful.

> Source/WebCore/workers/service/server/SWServerRegistration.h:41
> +    SWServerRegistration(SWServer&);

Explicit?