[webkit-reviews] review granted: [Bug 175936] Weird getComputedStyle behavior for pseudo-elements on layout-dependent properties. : [Attachment 318997] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 25 05:17:05 PDT 2017


Antti Koivisto <koivisto at iki.fi> has granted Emilio Cobos Álvarez [:emilio]
<emilio at crisal.io>'s request for review:
Bug 175936: Weird getComputedStyle behavior for pseudo-elements on
layout-dependent properties.
https://bugs.webkit.org/show_bug.cgi?id=175936

Attachment 318997: Patch

https://bugs.webkit.org/attachment.cgi?id=318997&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 318997
  --> https://bugs.webkit.org/attachment.cgi?id=318997
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318997&action=review

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2386
> +RenderObject* ComputedStyleExtractor::styledRenderObject() const

styledRenderer() would be a better name. Also this can return RenderElement*


More information about the webkit-reviews mailing list