[webkit-reviews] review granted: [Bug 175974] CacheQueryOptions::isolatedCopy() copies the cache name twice : [Attachment 319054] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 175974: CacheQueryOptions::isolatedCopy() copies the cache name twice
https://bugs.webkit.org/show_bug.cgi?id=175974

Attachment 319054: Patch

https://bugs.webkit.org/attachment.cgi?id=319054&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 319054
  --> https://bugs.webkit.org/attachment.cgi?id=319054
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319054&action=review

> Source/WebCore/Modules/cache/CacheQueryOptions.h:-47
> -    , cacheName(cacheName.isolatedCopy())

Wouh, that is a strange constructor!
This constructor might be needed for some platforms since CacheQueryOptions is
initializing some variables.
If this patch compiles on win, this patch is fine.
Otherwise, the constructor should be kept and take a String&&.

r=me, waiting for win bot