[webkit-reviews] review granted: [Bug 173937] Update configure-xcode-for-ios-development for iOS 11 : [Attachment 319018] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 173937: Update configure-xcode-for-ios-development for iOS 11
https://bugs.webkit.org/show_bug.cgi?id=173937

Attachment 319018: Patch

https://bugs.webkit.org/attachment.cgi?id=319018&action=review




--- Comment #10 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 319018
  --> https://bugs.webkit.org/attachment.cgi?id=319018
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319018&action=review

> Tools/ChangeLog:9
> +	   Xcode 9 has removed some headers required by WebKit builds for
testing.

If it is straightforward to do so it would be great to list the headers that
were removed and what SDK they were removed from. We should also explain what
we are doing to fix this issue: we are copying the missing headers from the
active macOS SDK.

> Tools/Scripts/configure-xcode-for-ios-development:71
> +copyMissingHeadersFromSDKToSDKIfNeeded("macosx", "iphonesimulator");

Out of curiosity what headers would actually be copied (i.e. what headers are
missing from the iphonesimulator 11 SDK)?