[webkit-reviews] review canceled: [Bug 173937] Update configure-xcode-for-ios-development for iOS 11 : [Attachment 319016] Patch

[bugzilla-daemon at webkit.org]

Jonathan Bedard <jbedard at apple.com> has canceled Jonathan Bedard
<jbedard at apple.com>'s request for review:
Bug 173937: Update configure-xcode-for-ios-development for iOS 11
https://bugs.webkit.org/show_bug.cgi?id=173937

Attachment 319016: Patch

https://bugs.webkit.org/attachment.cgi?id=319016&action=review




--- Comment #8 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 319016
  --> https://bugs.webkit.org/attachment.cgi?id=319016
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319016&action=review

>> Tools/Scripts/configure-xcode-for-ios-development:115
>> +		print "Successfully copied $macSDKPath to
$iphonesimulatorSDKPath and $iphoneosSDKPath.\n";
> 
> You seem to have disregarded the last sentence of my remark in comment #3
without explanation.I don't think the combined success message here is worth
much. Regardless, I suggest we take the approach I outlined in comment #4.

I isolated the duplicated code and placed it in a function.  I would be open to
moving the print statements to the function as well, but I don't feel like the
print statements are really duplicated code.

As for the approach you suggest in comment #4, I think you may be suggesting
some functions we don't need, but I like the general idea.  I'll update this
bug shortly.