[webkit-reviews] review granted: [Bug 175924] Add support for RegExp "dotAll" flag : [Attachment 319014] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 24 13:27:31 PDT 2017


Keith Miller <keith_miller at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 175924: Add support for RegExp "dotAll" flag
https://bugs.webkit.org/show_bug.cgi?id=175924

Attachment 319014: Patch

https://bugs.webkit.org/attachment.cgi?id=319014&action=review




--- Comment #3 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 319014
  --> https://bugs.webkit.org/attachment.cgi?id=319014
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=319014&action=review

r=me.

> Source/JavaScriptCore/bytecode/BytecodeDumper.cpp:-263
> -    if (regExp->sticky())

Why'd you move sticky out of curiosity?


More information about the webkit-reviews mailing list