[webkit-reviews] review granted: [Bug 129879] Geoclue2 based backend should provide the right desktop ID : [Attachment 318934] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Adrian Perez
<aperez at igalia.com>'s request for review:
Bug 129879: Geoclue2 based backend should provide the right desktop ID
https://bugs.webkit.org/show_bug.cgi?id=129879

Attachment 318934: Patch

https://bugs.webkit.org/attachment.cgi?id=318934&action=review




--- Comment #15 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 318934
  --> https://bugs.webkit.org/attachment.cgi?id=318934
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318934&action=review

> Source/WebCore/platform/geoclue/GeolocationProviderGeoclue.cpp:141
> +    // also fallback to our old behaviour of using g_get_prgname().

So I would still prefer if you changed the spelling.

> Source/WebKit/UIProcess/API/glib/WebKitGeolocationPermissionRequest.cpp:43
> + * ## Developer Notes

All of the documentation is developer notes, so this heading is useless. I'd
just remove it.

> Source/WebKit/UIProcess/API/glib/WebKitGeolocationPermissionRequest.cpp:58
> + * during initialization *might* be needed when the name of the executable

It will be needed, not "might."