[webkit-reviews] review granted: [Bug 175852] Race condition in StartWebThread causing crash : [Attachment 318880] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki
<utatane.tea at gmail.com>'s request for review:
Bug 175852: Race condition in StartWebThread causing crash
https://bugs.webkit.org/show_bug.cgi?id=175852

Attachment 318880: Patch

https://bugs.webkit.org/attachment.cgi?id=318880&action=review




--- Comment #7 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 318880
  --> https://bugs.webkit.org/attachment.cgi?id=318880
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318880&action=review

r=me.

> Source/WebCore/ChangeLog:9
> +	   by using pthread_cond_t. However, the main thread may be waken up
due to the the existence of

/waken/woken/.

> Source/WebCore/ChangeLog:10
> +	   the suspicious wakeup of the pthread_cond_t.

/suspicious/spurious/.

> Source/WebCore/ChangeLog:14
> +	   does not have the suspicious wakup problem as described in
Condition.h.

/suspicious/spurious/.
/wakup/wake up/.