[webkit-reviews] review granted: [Bug 175346] Default passive touch event listeners on the root : [Attachment 318849] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Dean Jackson <dino at apple.com>'s request
for review:
Bug 175346: Default passive touch event listeners on the root
https://bugs.webkit.org/show_bug.cgi?id=175346

Attachment 318849: Patch

https://bugs.webkit.org/attachment.cgi?id=318849&action=review




--- Comment #8 from Sam Weinig <sam at webkit.org> ---
Comment on attachment 318849
  --> https://bugs.webkit.org/attachment.cgi?id=318849
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318849&action=review

> Source/WebCore/ChangeLog:12
> +	   now in the DOM specification:

This doesn't seem to be in the DOM spec yet.  It still has passive as having a
default value of false.

> Source/WebCore/ChangeLog:19
> +	   If the event listener explicitly defines "passive" to false in their
> +	   options dictionary, then the behaviour is overridden.

This sentence took me a while to figure out what you mean by "the behavior".

> Source/WebCore/dom/EventTarget.cpp:72
> +    std::optional<bool> passive = options.passive;

You could use auto here.