[webkit-reviews] review granted: [Bug 175858] _WKThumbnailView should use the screen color space instead of sRGB : [Attachment 318840] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 175858: _WKThumbnailView should use the screen color space instead of sRGB
https://bugs.webkit.org/show_bug.cgi?id=175858

Attachment 318840: Patch

https://bugs.webkit.org/attachment.cgi?id=318840&action=review




--- Comment #13 from Dean Jackson <dino at apple.com> ---
Comment on attachment 318840
  --> https://bugs.webkit.org/attachment.cgi?id=318840
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318840&action=review

> Source/WebKit/ChangeLog:13
> +	   if the snapshot was instead originally painted in display space.

s/painted/taken/ ?

> Source/WebCore/platform/PlatformScreen.h:45
> +typedef struct CGColorSpace *CGColorSpaceRef;

We are inconsistent through WebCore as to whether the * should be on the left
or right :(

> Source/WebKit/Shared/cg/ShareableBitmapCG.cpp:42
> +    return configuration.colorSpace.cgColorSpace.get() ?:
sRGBColorSpaceRef();

What does this do? :)