[webkit-reviews] review granted: [Bug 174590] Support compiling catch in the DFG : [Attachment 318835] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 22 18:17:56 PDT 2017


Filip Pizlo <fpizlo at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 174590: Support compiling catch in the DFG
https://bugs.webkit.org/show_bug.cgi?id=174590

Attachment 318835: patch

https://bugs.webkit.org/attachment.cgi?id=318835&action=review




--- Comment #71 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 318835
  --> https://bugs.webkit.org/attachment.cgi?id=318835
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318835&action=review

Seems legit.

> Source/JavaScriptCore/dfg/DFGCFAPhase.cpp:98
> -		   
> +

Revert

> Source/JavaScriptCore/dfg/DFGCFG.h:99
> +template <typename T, typename = typename std::enable_if<std::is_same<T,
CPSCFG>::value>::type>
> +CPSCFG& selectCFG(Graph& graph)

Whoa.  What does this magic do?

> Source/WTF/wtf/BackwardsGraph.h:44
> +    using Node = SingleRootGraphNode<Graph>;
> +    using Set = SingleRootGraphSet<Graph>;
> +    template <typename T> using Map = SingleRootMap<T, Graph>;

Nice


More information about the webkit-reviews mailing list