[webkit-reviews] review denied: [Bug 175864] [WPE] Some event handlers not working. : [Attachment 318837] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 22 18:07:11 PDT 2017


Michael Catanzaro <mcatanzaro at igalia.com> has denied Carlos Alberto Lopez Perez
<clopez at igalia.com>'s request for review:
Bug 175864: [WPE] Some event handlers not working.
https://bugs.webkit.org/show_bug.cgi?id=175864

Attachment 318837: Patch

https://bugs.webkit.org/attachment.cgi?id=318837&action=review




--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 318837
  --> https://bugs.webkit.org/attachment.cgi?id=318837
Patch

Good work, but it seems now the files are identical except for
EventHandler::shouldTurnVerticalTicksIntoHorizontal, right? Or nearly so? We
should merge these files and use #if PLATFORM(GTK) where necessary to avoid
duplicate code.


More information about the webkit-reviews mailing list