[webkit-reviews] review granted: [Bug 175854] Platform code should be able to safely log in release builds : [Attachment 318814] Proposed patch.

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 175854: Platform code should be able to safely log in release builds
https://bugs.webkit.org/show_bug.cgi?id=175854

Attachment 318814: Proposed patch.

https://bugs.webkit.org/attachment.cgi?id=318814&action=review




--- Comment #4 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 318814
  --> https://bugs.webkit.org/attachment.cgi?id=318814
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=318814&action=review

r=me with maybe a nit, maybe not a nit.

> Source/WebCore/PAL/pal/Logger.h:94
> +    bool enabled() const { return m_enabled; }

nit: I don't know where we (as a project) come down on "bool enabled()" v.
"bool isEnabled()".  I could go either way.