[webkit-reviews] review granted: [Bug 175815] REGRESSION(r216718): Speedometer 2.0: Fix vanilla JS examples : [Attachment 318744] Fixes the bug

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 175815: REGRESSION(r216718): Speedometer 2.0: Fix vanilla JS examples
https://bugs.webkit.org/show_bug.cgi?id=175815

Attachment 318744: Fixes the bug

https://bugs.webkit.org/attachment.cgi?id=318744&action=review




--- Comment #6 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 318744
  --> https://bugs.webkit.org/attachment.cgi?id=318744
Fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=318744&action=review

>>>
PerformanceTests/Speedometer/resources/todomvc/vanilla-examples/es2015-babel-we
bpack/src/store.js:5
>>> +var uniqueID = 0;
>> 
>> `vanilla-examples/es2015/src/store.js` has the same line but uses `let`
instead of `var` and starts at `1` instead of `0`. Is there a reason for these
subtle differences? If so, we may want to add a comment saying so.
> 
> It looked like all variable declarations in this file was using `var` so I
used that to be consistent.
> 
> (In reply to Mathias Bynens from comment #4)

As Mathias asked, is there a reason to use 0 instead of 1 or vice versa?