[webkit-reviews] review granted: [Bug 174646] Implement Unicode RegExp support in the YARR JIT : [Attachment 318789] Updated Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 22 13:53:05 PDT 2017


Filip Pizlo <fpizlo at apple.com> has granted Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 174646: Implement Unicode RegExp support in the YARR JIT
https://bugs.webkit.org/show_bug.cgi?id=174646

Attachment 318789: Updated Patch

https://bugs.webkit.org/attachment.cgi?id=318789&action=review




--- Comment #7 from Filip Pizlo <fpizlo at apple.com> ---
Comment on attachment 318789
  --> https://bugs.webkit.org/attachment.cgi?id=318789
Updated Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318789&action=review

LGTM

> Source/JavaScriptCore/ChangeLog:38
> +	   function, getEffectiveAddress64(), for ARM64.  It just calls
x86Lea64() on X86-64.

Nice.


More information about the webkit-reviews mailing list