[webkit-reviews] review granted: [Bug 175808] Web Inspector: Relax the maximum sidebar width : [Attachment 318722] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <webkit at devinrousso.com> has granted Matt Baker
<mattbaker at apple.com>'s request for review:
Bug 175808: Web Inspector: Relax the maximum sidebar width
https://bugs.webkit.org/show_bug.cgi?id=175808

Attachment 318722: Patch

https://bugs.webkit.org/attachment.cgi?id=318722&action=review




--- Comment #5 from Devin Rousso <webkit at devinrousso.com> ---
Comment on attachment 318722
  --> https://bugs.webkit.org/attachment.cgi?id=318722
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318722&action=review

>>> Source/WebInspectorUI/UserInterface/Base/Main.js:1053
>>> +	 const minimumContentBrowserWidth = 150;
>> 
>> Should we have a FIXME for making this number more dynamic?
> 
> I'd rather not have the minimum change based on the content view, that could
be surprising. Instead it would be better to build better collapsing support
into our toolbars.

OK that sounds good.  A comment explaining how you arrived at 150 would be nice
though :)