[webkit-reviews] review granted: [Bug 175653] Speculatively change iteration protocall to use the same next function : [Attachment 318685] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 175653: Speculatively change iteration protocall to use the same next
function
https://bugs.webkit.org/show_bug.cgi?id=175653

Attachment 318685: Patch

https://bugs.webkit.org/attachment.cgi?id=318685&action=review




--- Comment #19 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 318685
  --> https://bugs.webkit.org/attachment.cgi?id=318685
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318685&action=review

r=me

Please add tests that verify "next" is only accessed once per for-of, spread,
and anything else that does the protocol (not sure if there is anything else
off the top of my head)

> Source/JavaScriptCore/ChangeLog:13
> +	   See: https://github.com/tc39/ecma262/issues/976

Let's also have a bugzilla that tracks if you haven't already made one.