[webkit-reviews] review granted: [Bug 175270] REGRESSION (r220052): ASSERTION FAILED: !frame().isMainFrame() || !needsStyleRecalcOrLayout() in WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive() : [Attachment 318760] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 175270: REGRESSION (r220052): ASSERTION FAILED: !frame().isMainFrame() ||
!needsStyleRecalcOrLayout()  in
WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive()
https://bugs.webkit.org/show_bug.cgi?id=175270

Attachment 318760: Patch

https://bugs.webkit.org/attachment.cgi?id=318760&action=review




--- Comment #7 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 318760
  --> https://bugs.webkit.org/attachment.cgi?id=318760
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318760&action=review

> Source/WebCore/page/FrameView.cpp:4599
> +	   AnimationUpdateBlock animationUpdateBlock(&frame().animation());

I think AnimationUpdateBlock should be outside this lambda; all the passes
should use the same animation start time.