[webkit-reviews] review granted: [Bug 175812] We are using valueProfileForBytecodeOffset when there may not be a value profile : [Attachment 318740] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 22 07:26:19 PDT 2017


Michael Saboff <msaboff at apple.com> has granted Saam Barati
<sbarati at apple.com>'s request for review:
Bug 175812: We are using valueProfileForBytecodeOffset when there may not be a
value profile
https://bugs.webkit.org/show_bug.cgi?id=175812

Attachment 318740: patch

https://bugs.webkit.org/attachment.cgi?id=318740&action=review




--- Comment #3 from Michael Saboff <msaboff at apple.com> ---
Comment on attachment 318740
  --> https://bugs.webkit.org/attachment.cgi?id=318740
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318740&action=review

r=me with the suggested build fix.

> Source/JavaScriptCore/jit/JITInlines.h:974
>      ASSERT(valueProfile);

Looks like this line needs to be removed to fix the Debug build.


More information about the webkit-reviews mailing list