[webkit-reviews] review granted: [Bug 175811] Speedometer 2.0: Make it possible to change the iteration count via query string : [Attachment 318738] Patch

[bugzilla-daemon at webkit.org]

Saam Barati <sbarati at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 175811: Speedometer 2.0: Make it possible to change the iteration count via
query string
https://bugs.webkit.org/show_bug.cgi?id=175811

Attachment 318738: Patch

https://bugs.webkit.org/attachment.cgi?id=318738&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 318738
  --> https://bugs.webkit.org/attachment.cgi?id=318738
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318738&action=review

> PerformanceTests/Speedometer/resources/main.js:160
> +	       case 'unit':

Why have this parameter if only “ms” is allowed?

> PerformanceTests/Speedometer/resources/main.js:168
> +		   if (!isNaN(value))

Should be isNaN(parsedValue)