[webkit-reviews] review denied: [Bug 175813] Performance Dashboard should be compatible with PHP 7. : [Attachment 318739] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied dewei_zhu at apple.com's request for
review:
Bug 175813: Performance Dashboard should be compatible with PHP 7.
https://bugs.webkit.org/show_bug.cgi?id=175813

Attachment 318739: Patch

https://bugs.webkit.org/attachment.cgi?id=318739&action=review




--- Comment #2 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 318739
  --> https://bugs.webkit.org/attachment.cgi?id=318739
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318739&action=review

r- because I don't think we should be asking people to override config.json
like this.

> Websites/perf.webkit.org/ReadMe.md:52
> +(If you have a PHP 7 installed, please make sure `phpVersion` in
`config.json` is updated to 'PHP7', by default it's 'PHP5'.
> +)

I don't think should force everyone to manually edit JSON like this.

> Websites/perf.webkit.org/config.json:27
> +	   "httpdMutexDir": "/tmp/org.webkit.perf.tests/",
> +	   "phpVersion": "PHP5"

Instead of specifying PHP version like that, we should just pick the right
module based on the result of php -v.

> Websites/perf.webkit.org/server-tests/resources/test-server.js:173
> +	   let phpVersion = Config.value('testServer.phpVersion');

Just do: ChildProcess.execFileSync('php', ['-v']).includes('PHP 5') ? 'PHP5' :
'PHP7';