[webkit-reviews] review granted: [Bug 175809] Make generate_offset_extractor.rb architetures argument more robust : [Attachment 318726] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 175809: Make generate_offset_extractor.rb architetures argument more robust
https://bugs.webkit.org/show_bug.cgi?id=175809

Attachment 318726: Patch

https://bugs.webkit.org/attachment.cgi?id=318726&action=review




--- Comment #2 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 318726
  --> https://bugs.webkit.org/attachment.cgi?id=318726
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318726&action=review

> Source/JavaScriptCore/ChangeLog:3
> +	   Make generate_offset_extractor.rb architetures argument more robust

Typo in bug name: architetures

> Source/JavaScriptCore/offlineasm/generate_offset_extractor.rb:42
> -validBackends = canonicalizeBackendNames(ARGV.shift.split(","))
> +validBackends = canonicalizeBackendNames(ARGV.shift.split(/,+\s*|\s+/))

How about:

    /[,\s]+/

This to require any combination of spaces and commas. Your regex supports
leading commands and trailing whitespace but not emptiness in-between, which
seems weird.