[webkit-reviews] review granted: [Bug 175746] [Beacon] Content extensions should be able to intercept Beacon / Ping redirects : [Attachment 318678] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 175746: [Beacon] Content extensions should be able to intercept Beacon /
Ping redirects
https://bugs.webkit.org/show_bug.cgi?id=175746

Attachment 318678: Patch

https://bugs.webkit.org/attachment.cgi?id=318678&action=review




--- Comment #9 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 318678
  --> https://bugs.webkit.org/attachment.cgi?id=318678
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318678&action=review

> Source/WebKit/NetworkProcess/PingLoad.cpp:129
>	       completionHandler({ });
> +	       didFinish(ResourceError { String(), 0, currentRequest().url(),
ASCIILiteral("Blocked by Content Security Policy"),
ResourceError::Type::AccessControl });

I think it would be nicer if the didFinish calls were before the
completionHandler calls.