[webkit-reviews] review granted: [Bug 175755] [Payment Request] Implement the PaymentRequest constructor : [Attachment 318612] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 175755: [Payment Request] Implement the PaymentRequest constructor
https://bugs.webkit.org/show_bug.cgi?id=175755

Attachment 318612: Patch

https://bugs.webkit.org/attachment.cgi?id=318612&action=review




--- Comment #9 from Darin Adler <darin at apple.com> ---
Comment on attachment 318612
  --> https://bugs.webkit.org/attachment.cgi?id=318612
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318612&action=review

> Source/WebCore/Modules/paymentrequest/PaymentRequest.cpp:55
> +static bool isValidDecimalMonetaryValue(const String& value)

Should take a StringView.

> Source/WebCore/Modules/paymentrequest/PaymentRequest.cpp:66
> +    for (unsigned i = 0; i < value.length(); ++i) {

Should use a modern for loop since StringView offers that:

    for (auto character : value.codeUnits()) {