[webkit-reviews] review granted: [Bug 175761] [EME] HTMLMediaElement: basic implementations of 'Attempt to Decrypt', 'Attempt to Resume Playback If Necessary' : [Attachment 318617] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Zan Dobersek
<zan at falconsigh.net>'s request for review:
Bug 175761: [EME] HTMLMediaElement: basic implementations of 'Attempt to
Decrypt', 'Attempt to Resume Playback If Necessary'
https://bugs.webkit.org/show_bug.cgi?id=175761

Attachment 318617: Patch

https://bugs.webkit.org/attachment.cgi?id=318617&action=review




--- Comment #3 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 318617
  --> https://bugs.webkit.org/attachment.cgi?id=318617
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318617&action=review

> Source/WebCore/ChangeLog:15
> +	   the platform layer. The gist of the algorithm is to invoke the
decryption

gist?

> Source/WebCore/ChangeLog:17
> +	   retrieved from the MediaKeys object that's associated with this
media

I've never seen that's contracted when that is the subordinate pronoun, but I
might be wrong...

> Source/WebCore/Modules/encryptedmedia/MediaKeys.cpp:140
> +	   [](auto& session) { return !session->isClosed(); });

Fix the style checker complain. And it looks like you should leave a space
between the [] and the (