[webkit-reviews] review granted: [Bug 175509] [iOS WK2] Add a version of DataInteractionTests.ExternalSourceAttributedStringToContentEditable that doesn't hit a debug assertion : [Attachment 318536] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 175509: [iOS WK2] Add a version of
DataInteractionTests.ExternalSourceAttributedStringToContentEditable that
doesn't hit a debug assertion
https://bugs.webkit.org/show_bug.cgi?id=175509

Attachment 318536: Patch

https://bugs.webkit.org/attachment.cgi?id=318536&action=review




--- Comment #8 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 318536
  --> https://bugs.webkit.org/attachment.cgi?id=318536
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318536&action=review

> Tools/ChangeLog:11
> +	   Clone ExternalSourceAttributedStringToContentEditable to
ExternalSourceColoredAttributedStringToContentEditable,
> +	   which tests an attributed string with colored text instead of a bold
attributed string of system font. Due to a
> +	   recent change in behavior in UIKit, this test is hitting a debug
assertion. The purpose of this test is to verify

Could you clarify that you're adding a test which changes color because bold
case is crashing.