[webkit-reviews] review granted: [Bug 175713] [Curl] Improve multi-threaded networking : [Attachment 318477] patch part 2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 18 13:18:14 PDT 2017
Alex Christensen <achristensen at apple.com> has granted Daewoong Jang
<daewoong.jang at navercorp.com>'s request for review:
Bug 175713: [Curl] Improve multi-threaded networking
https://bugs.webkit.org/show_bug.cgi?id=175713
Attachment 318477: patch part 2
https://bugs.webkit.org/attachment.cgi?id=318477&action=review
--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 318477
--> https://bugs.webkit.org/attachment.cgi?id=318477
patch part 2
View in context: https://bugs.webkit.org/attachment.cgi?id=318477&action=review
> Source/WebCore/platform/network/curl/CurlDownload.cpp:62
> - m_url = url;
> + m_url = url.isolatedCopy();
I don't think this is necessary. This is not the point at which we are moving
to another thread.
> Source/WebCore/platform/network/curl/CurlJobManager.cpp:86
> + default:
> + ASSERT_NOT_REACHED();
This should be removed.
More information about the webkit-reviews
mailing list