[webkit-reviews] review granted: [Bug 174615] WebDriver: implement screen capture commands : [Attachment 318355] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 174615: WebDriver: implement screen capture commands
https://bugs.webkit.org/show_bug.cgi?id=174615

Attachment 318355: Patch

https://bugs.webkit.org/attachment.cgi?id=318355&action=review




--- Comment #3 from Brian Burg <bburg at apple.com> ---
Comment on attachment 318355
  --> https://bugs.webkit.org/attachment.cgi?id=318355
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318355&action=review

r=me

Please re-run through EWS.

> Source/WebKit/ChangeLog:16
> +	   checkjed and passed to the web process.

Nit: checked

> Source/WebKit/WebProcess/Automation/WebAutomationSessionProxy.cpp:691
>      RefPtr<WebImage> image = page->scaledSnapshotWithOptions(snapshotRect,
1, SnapshotOptionsShareable);

We received a bug the other day that the scale factor should be inherited from
the device. Right now, retina screenshots are at @1x and look blurry. But
that's a separate bug.