[webkit-reviews] review granted: [Bug 175729] [Repaint Outside Layout] Add a pref for repainting outside of layout : [Attachment 318523] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Dave Hyatt <hyatt at apple.com>'s
request for review:
Bug 175729: [Repaint Outside Layout] Add a pref for repainting outside of
layout
https://bugs.webkit.org/show_bug.cgi?id=175729

Attachment 318523: Patch

https://bugs.webkit.org/attachment.cgi?id=318523&action=review




--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 318523
  --> https://bugs.webkit.org/attachment.cgi?id=318523
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318523&action=review

> Source/WebCore/rendering/RenderElement.cpp:2191
> +    if (document().view()->needsFullRepaint() || !everHadLayout() ||
hasSelfPaintingLayer())
> +	   return false;
> +    return !settings().repaintOutsideLayoutEnabled();

I take it you feel this reads better. I would have written this using one line
without a branch:

return !document().view()->needsFullRepaint() && everHadLayout() &&
!hasSelfPaintingLayer() && !settings().repaintOutsideLayoutEnabled();