[webkit-reviews] review granted: [Bug 175658] [Cache API] Add response body storage : [Attachment 318514] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 18 10:48:30 PDT 2017


Alex Christensen <achristensen at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 175658: [Cache API] Add response body storage
https://bugs.webkit.org/show_bug.cgi?id=175658

Attachment 318514: Patch

https://bugs.webkit.org/attachment.cgi?id=318514&action=review




--- Comment #9 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 318514
  --> https://bugs.webkit.org/attachment.cgi?id=318514
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318514&action=review

> Source/WebKit/Shared/WebCoreArgumentCoders.cpp:114
> +static void encodeSharedBuffer(Encoder& encoder, const SharedBuffer* buffer)

We're just moving this code to use it below?  We already kind of have this in
SharedBufferDataReference.  This should be united with that, and maybe that
should be cleaned up.


More information about the webkit-reviews mailing list